Update cats to 0.8.1 and add Scala 2.12 support #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will not build until monix 2.1 is released (later today ?) This also updated scalafmt, so some parts of the code are reformated as a consequence.
Current coverage is 75.66% (diff: 69.04%)@@ master #80 diff @@
==========================================
Files 8 9 +1
Lines 228 226 -2
Methods 226 224 -2
Messages 0 0
Branches 2 2
==========================================
- Hits 173 171 -2
Misses 55 55
Partials 0 0
|
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated cats to 0.8.1 (and monix to the compatible 2.1.0).
I think that all our dependencies and plugins now make it possible to also release for Scala 2.12.0.
The cats changes are mostly changing
Xor/XorTtoEither/EitherTand removing theRecursiveTailRecMevidence. I added theFromMonadErrorclass which makes it easier to implementFetchMonadError[M]given aMonadError[M, Throwable](mostly so that we are spared from reimplementingtailRecM).I updated the scalafmt version which triggered some code reformatting. There is apparently an issue with sbt and scalafmt (sbt/sbt#2786) which keeps us from using sbt 0.13.13.
Fixes #72 and #68.
@dialelo and @juanpedromoreno, would you like to take a look?