New implementation parallel joins #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 76.03% (diff: 87.71%)@@ master #84 diff @@
==========================================
Files 9 10 +1
Lines 226 242 +16
Methods 224 240 +16
Messages 0 0
Branches 2 2
==========================================
+ Hits 171 184 +13
- Misses 55 58 +3
Partials 0 0
|
|
I'll rebase this on the current master. |
This adds the `Join` construct to the underlying Fetch structure. The `Join`s are paralellized in a new interpreter `parallelJoinPhase`. The new parallel optimization fiddles with the `Free` structure to look for independent queries and to simplify queries if the results are cached. Everything in a `fetch.map(...)` or `fetch.flatMap(...)` should be only executed once (currently this isn't yet the case for pure fetches created with `Fetch.pure`).
peterneyens
force-pushed
the
peter-refactor-join-2
branch
from
d5187cd
to
53b443a
Compare
Closed
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the way fetches are inspected to parallelize independent fetches. It does this by adding a new
Joinconstruct to theFetchstructure. ThisJoinis parallelized in a new intermediate interpreter which inspects the actualFreeconstructs and replaces cached fetches byFree.Pure.It does play a bit fast and loose with the laws with this fiddling with
Freeunder the hood, but it now executes code in afetch.map(...)or afetch.flatMap(...)only once.(The other PR updating cats and adding Scala 2.12 support should be merged first).