Fixes Cross Publishing #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch! LGTM |
|
It seems I didn't check the documentation for 2.11 after the cats update, I think we are missing |
Current coverage is 76.03% (diff: 100%)@@ master #86 diff @@
==========================================
Files 10 10
Lines 242 242
Methods 240 240
Messages 0 0
Branches 2 2
==========================================
Hits 184 184
Misses 58 58
Partials 0 0
|
|
👍 Thanks for cleaning up after me 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've just realized we should cross-publish with
+publishSignedinstead of justpublishSigned, now that we have cross compatibility through scala2.11and2.12. Also, if we don't applyallSettingsto the root project, the cross versioning starts with scala2.10.This PR comes to fix it.
@dialelo @peterneyens could you take a look? Thanks!