Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Compatibility with Scala 2.10 #90

Merged
merged 3 commits into from
Nov 22, 2016
Merged

Fixes Compatibility with Scala 2.10 #90

merged 3 commits into from
Nov 22, 2016

Conversation

juanpedromoreno
Copy link
Contributor

This PR fixes/adds:

  • Adds scala 2.10 to the travis file to run the tests for this scala version.
  • Fixes compatibility with Scala 2.10 adding the paradise compiler plugin (needed when using with the kind-projector and Scala 2.10).
  • Fixes docs (divergence implicits issue) for Scala 2.10 with -Xdivergence211 compiler flag.
  • Upgrades sbt-catalysts-extras, squeezing all the plugin dependencies into a single one.
  • Cats, kind-projector, monix and scalatest dependencies are using the same versions as before, but in this case, through the sbt-catalysts-extras plugin.

Please, @dialelo @raulraja could you review? Thanks!

@raulraja
Copy link
Contributor

raulraja commented Nov 21, 2016 •
edited

LGTM! /cc @adelbertc

@juanpedromoreno juanpedromoreno merged commit 7fd03f5 into master Nov 22, 2016
@juanpedromoreno juanpedromoreno deleted the adds-sbt-2.10-in-travis-file branch November 22, 2016 16:21
@adelbertc
Copy link
Contributor

Hurrah!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@juanpedromoreno @raulraja @adelbertc