Update Cats and Monix #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 76.79% (diff: 100%)@@ master #99 diff @@
==========================================
Files 10 10
Lines 240 237 -3
Methods 238 235 -3
Messages 0 0
Branches 2 2
==========================================
- Hits 184 182 -2
+ Misses 56 55 -1
Partials 0 0
|
|
Awesome, LGTM |
ghost
approved these changes
Jan 26, 2017
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some code clean up using
Reducible#reduceMapMand the now covariantNonEmptyList.The http4s-circe version still depends on circe 0.6.1 and thus cats 0.8.1. It is only used in the example project of Fetch, so it doesn't matter here, but we should probably update sbt-catalysts-extras once a new http4s version comes out.
Resolves #98