New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put and patch are coerced to post on the JVM #119

Closed

BenFradet opened this issue May 6, 2017 · 0 comments

Contributor

BenFradet commented May 6, 2017 •

edited

httpClient.patch[Issue](
  accessToken,
  s"repos/$owner/$repo/issues/$issue",
  headers,
  data = EditIssueRequest(state, title, body, milestone, labels, assignees).asJson.noSpaces)

will result in a POST on the JVM due to postData changing the verb to POST in scalaj.

A fix would imply changes to MockGithubApiServer where httpClient.patch are expected to be post (for the Issue and GitData APIs).

The text was updated successfully, but these errors were encountered:

AdrianRaFo mentioned this issue

Arf 97 support notifications api #123

Merged

fedefernandez closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment