Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update detekt #20

Closed
AdrianRaFo opened this issue Nov 6, 2018 · 4 comments
Closed

Update detekt #20

AdrianRaFo opened this issue Nov 6, 2018 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@AdrianRaFo
Copy link
Contributor

We need to update https://github.com/arturbosch/detekt to the last version RC 9.2 in maven and update the detekt.yml according to the kotlin style guide https://kotlinlang.org/docs/reference/coding-conventions.html
@AdrianRaFo AdrianRaFo added enhancement New feature or request good first issue Good for newcomers labels Nov 6, 2018
@AdrianRaFo AdrianRaFo mentioned this issue Nov 13, 2018
Merged
@AdrianRaFo
Copy link
Contributor Author

AdrianRaFo commented Dec 18, 2018 •
edited

The Detekt version is already updated to 9.2 and related to the formatting issue we have this detekt/detekt#652.
For now, we have set the kotlin.code.style=official on Gradle properties to follow the official style rules.

@fedefernandez
Copy link
Contributor

So, is this already done?

@AdrianRaFo
Copy link
Contributor Author

Until the detekt issue was closed part of this is on hold, the other part is already done

@fedefernandez
Copy link
Contributor

Got it, thanks

@AdrianRaFo AdrianRaFo mentioned this issue Feb 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fedefernandez @AdrianRaFo