Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the build #531

Closed
sloshy opened this issue Jan 15, 2021 · 2 comments
Closed

Fix the build #531

sloshy opened this issue Jan 15, 2021 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@sloshy
Copy link
Contributor

sloshy commented Jan 15, 2021

In both #530 and #529, both of which have relatively inconsequential changes (especially #530) the build appears to be broken. sbt microsite/makeMicrosite seems to be failing and the root cause needs to be found out.

So far from what I can tell, it is failing because the file microsite/target/scala-2.12/resource_managed/main/jekyll/img/light_navbar_brand.png is empty.

@sloshy sloshy self-assigned this Jan 15, 2021
@sloshy
Copy link
Contributor Author

sloshy commented Jan 20, 2021

The source of the issue, and resolution, had something to do with the way the old code behaved. I'm not entirely sure what it was, but, rewriting the JAR export code to use java.nio.file.FileSystem instead, everything works as you would expect. The resulting code I think is a bit smaller and easier to grok, and it also works on my machine as well as GitHub Actions.

What doesn't work now, is, Jekyll appears to not be installed. I will resume investigating this issue in the future, unless someone else wants to pick it up.

@calvellido
Copy link
Contributor

Just commenting without much context, but bear in mind that Jekyll is a system requirement for the project. Nothing in the process is gonna fetch it or install it.

Also, we have had cases where the Jekyll version is not ^4.0.0 and the process will think none is installed.

@sloshy sloshy closed this as completed Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants