Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Scrimage classloader hack #535

Closed
sloshy opened this issue Jan 26, 2021 · 0 comments · Fixed by #553
Closed

Remove Scrimage classloader hack #535

sloshy opened this issue Jan 26, 2021 · 0 comments · Fixed by #553
Assignees

Comments

@sloshy
Copy link
Contributor

sloshy commented Jan 26, 2021

As described here: sksamuel/scrimage#217

And mentioned here: #529

There's a hack in MicrositeHelper.scala def createFavicons for changing out the current ClassLoader for the duration of using the Scrimage library. In Scrimage 4.1.0, after the above issue is fixed, there may be a way to pass in a classloader of your own, so we will still need to get a new classloader but we will be able to pass it through to the library instead of swapping it on the current thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant