Skip to content
This repository has been archived by the owner on Feb 6, 2019. It is now read-only.

feat: support FormattedMessage intl components for namespaces #17

Merged
merged 3 commits into from Oct 19, 2018
Merged

Conversation

jquense
Copy link
Member

@jquense jquense commented Oct 18, 2018

No description provided.

Copy link
Contributor

@taion taion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i did some very small nits + a fix, go ahead and merge if they look good to you

function getPrefix(state) {
let prefix = state.opts.prefix;
if (!prefix.endsWith(':')) prefix = `${prefix}:`;
return prefix;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this previously wasn't returning

@jquense jquense merged commit e6fba0e into master Oct 19, 2018
@jquense jquense deleted the intl branch October 19, 2018 13:26
jquense pushed a commit that referenced this pull request Oct 19, 2018
<a name="4.1.0"></a>
# [4.1.0](v4.0.0...v4.1.0) (2018-10-19)

### Features

* support FormattedMessage intl components for namespaces ([#17](#17)) ([e6fba0e](e6fba0e))
@jquense
Copy link
Member Author

jquense commented Oct 19, 2018

🎉 This PR is included in version 4.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

jquense pushed a commit to 4Catalyzer/javascript that referenced this pull request Jan 29, 2019
<a name="4.1.0"></a>
# [4.1.0](4Catalyzer/babel-preset-4catalyzer@v4.0.0...v4.1.0) (2018-10-19)

### Features

* support FormattedMessage intl components for namespaces ([#17](4Catalyzer/babel-preset-4catalyzer#17)) ([e6fba0e](4Catalyzer/babel-preset-4catalyzer@e6fba0e))
jquense pushed a commit to 4Catalyzer/javascript that referenced this pull request Jan 29, 2019
<a name="4.1.0"></a>
# [4.1.0](4Catalyzer/babel-preset-4catalyzer@v4.0.0...v4.1.0) (2018-10-19)

### Features

* support FormattedMessage intl components for namespaces ([#17](4Catalyzer/babel-preset-4catalyzer#17)) ([e6fba0e](4Catalyzer/babel-preset-4catalyzer@e6fba0e))
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants