Don't use pure containers

4Catalyzer · Nov 1, 2016 · 4321134 · 4321134
1 parent af020b3
commit 4321134
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/src/createConnectedRouter.js b/src/createConnectedRouter.js
@@ -14,6 +14,12 @@ export default function createConnectedRouter({
       replace: FarceActions.replace,
       go: FarceActions.go,
     },
+    null,
+    {
+      // <BaseRouter> already memoizes its render output, so there's no benefit
+      // to doing further memoization here.
+      pure: false,
+    },
   )(createBaseRouter(options));
 
   // This implementation is very messy, but it provides the cleanest API to get

diff --git a/src/createWithRouter.js b/src/createWithRouter.js
@@ -17,6 +17,10 @@ export default function createWithRouter({
       ...stateProps,
       // We don't want dispatch here.
     }),
+    {
+      // We can't assume the wrapped component is pure.
+      pure: false,
+    },
   );
 
   return function withRouter(Component) {