Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: more types #1014

Merged
merged 14 commits into from
Dec 13, 2022
Merged

feat: more types #1014

merged 14 commits into from
Dec 13, 2022

Conversation

golota60
Copy link
Collaborator

@golota60 golota60 commented Dec 12, 2022

  • More types conversion
  • Added typeUtils.ts temp file(should be removed at the end of TS conversion) as a intermediary file that is a buffer with all the types that are in the declaration file
  • Removed build:ts from the build script cause mixing JS/TS/Hand-declared declarations is a BIG hassle(also it was kinda broken). Right now it builds the same way as it did before TS. I'll adjust it after the conversion
  • Left a couple of TODOs that should be easier to address once the whole repo is in TS
  • I've made 0 functional changes. Whenever i wanted to make one, I just left a todo(i don't want to mix TS conversion stuff with actual functional changes, cause when issues come up it's really hard to know what broke what). Those should be imporoved/addressed at the end of conversion IMO

@golota60 golota60 merged commit 63a44a6 into master Dec 13, 2022
@golota60 golota60 deleted the sw/more-types branch December 13, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants