Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass className in Link #1045

Merged
merged 2 commits into from
Feb 11, 2023
Merged

fix: pass className in Link #1045

merged 2 commits into from
Feb 11, 2023

Conversation

golota60
Copy link
Collaborator

Fixes: #1044

@golota60
Copy link
Collaborator Author

golota60 commented Feb 11, 2023

@jquense As a part of this, I've also inspected the output code of js build of 1.1.2 and the the current master, to ensure more silly stuff like this was not introduced. And it seems this + children not passed(which you fixed) were the only issues(I've also reverted only other behavioral change - foundReducer return value was a little bit different in one case - reverted cause someone might be relying on that). I think we should do a release of this once merged

On the bright side, this reminds me that i think tests need a little bit of a refresher 😄

}
: null;
return (
state && {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can state be some non null value here ?

Copy link
Collaborator Author

@golota60 golota60 Feb 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

state should never be null here afaics, but since this is technically a functional change i reverted it too

@golota60 golota60 merged commit bf690f9 into master Feb 11, 2023
@golota60 golota60 deleted the sw/fix-link branch February 11, 2023 16:56
@sushantdhiman
Copy link

Please release this fix @jquense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong className in Link component with activeClassName
3 participants