[typescript] Result of hoc withRouter should not require props provided by it #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good, can you add a test exercising the type in types/text.jsx |
|
It was already exercised, not sure why it was not erroring because it did downstream in my app. |
|
@jquense Should we merge as-is, then, or do you want to look at the test? |
|
I'll take another look at the script. |
|
Whomever added dtslint ignored the existing test files. |
|
oops, that's unfortunate. can you fix that? |
|
Ok, original typescript tests added and fixed up based on the dtslint rules. Should be good to go. |
|
@jquense Can you take another look? If it's good, I'll cut a release. |
jquense
approved these changes
Jan 1, 2019
|
released in v0.3.17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.