Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove instanceof checks for errors #266

Merged
merged 1 commit into from
Mar 5, 2019
Merged

fix: Remove instanceof checks for errors #266

merged 1 commit into from
Mar 5, 2019

Conversation

taion
Copy link
Contributor

@taion taion commented Mar 5, 2019

Fixes #210

@taion
Copy link
Contributor Author

taion commented Mar 5, 2019

@jquense wdyt? or should i do something complicated with Symbols here?

jquense
jquense approved these changes Mar 5, 2019
View reviewed changes
Copy link
Member

@jquense jquense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, symbols maybe nicer, but not worth the polyfill probably?

@taion
Copy link
Contributor Author

taion commented Mar 5, 2019

also clunkier to use... more exports and all that. this is still in prerelease anwyay

@taion taion merged commit ec79c30 into master Mar 5, 2019
@taion taion deleted the remove-instanceof branch March 5, 2019 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jquense jquense jquense approved these changes

Assignees

@jquense jquense

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@taion @jquense