feat: Allow route render methods to return a function #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
not sure if we should deprecate the old thing |
jquense
reviewed
Mar 5, 2019
jquense
reviewed
Mar 5, 2019
jquense
approved these changes
Mar 5, 2019
taion
commented
Mar 5, 2019
Co-Authored-By: taion <tesrin@gmail.com>
|
not going to deprecate the old API for now (among other things, the asymmetry between group and single child behavior that i think makes the API slightly nicer when writing these by hand also makes thing a bit more annoying to deal with things in an automated manner |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #125