Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use our own context #307

Merged
merged 3 commits into from
Apr 5, 2019
Merged

feat: Use our own context #307

merged 3 commits into from
Apr 5, 2019

Conversation

taion
Copy link
Contributor

@taion taion commented Mar 29, 2019 •
edited

BREAKING CHANGE: Remove custom connector utilities

Closes #242

@taion
feat: Use our own context
db1885f 
BREAKING CHANGE: Remove custom connector helpers
@taion
Copy link
Contributor Author

taion commented Mar 29, 2019

This would allow useContext(RouterContext), though I wonder if we should expose our own useRouter hook.

@taion
Copy link
Contributor Author

taion commented Apr 4, 2019

@jquense Any thoughts here?

@jquense
Copy link
Member

jquense commented Apr 4, 2019

SHHHHIIIIIIP IIIIIITTTT

@taion
Copy link
Contributor Author

taion commented Apr 4, 2019

@jquense should we ship a useRouter, or is useContext(RouterContext) the recommended approach?

@jquense
Copy link
Member

jquense commented Apr 5, 2019

I think useRouter since you don't need to expose the context otherwise, since router is the provider

@taion
Copy link
Contributor Author

taion commented Apr 5, 2019

I actually want to expose the context. It will make testing easier. But I think useRouter is probably a neater API.

@taion taion merged commit 2a90dcb into master Apr 5, 2019
@taion taion deleted the context branch April 5, 2019 14:29
@taion taion mentioned this pull request Apr 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jquense jquense jquense approved these changes

Assignees

@jquense jquense

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@taion @jquense