Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Abort resolving match on resolver changes #672

Merged
merged 2 commits into from
Mar 28, 2020
Merged

fix: Abort resolving match on resolver changes #672

merged 2 commits into from
Mar 28, 2020

Conversation

taion
Copy link
Contributor

@taion taion commented Mar 27, 2020

No description provided.

@taion taion requested review from ethanve and jquense March 27, 2020 04:08
@taion
Copy link
Contributor Author

taion commented Mar 27, 2020

ugh i should test this

jquense
jquense approved these changes Mar 27, 2020
View reviewed changes
Copy link
Member

@jquense jquense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems correct, but idk how it'll play out in more complex situations...A test would be good

@taion taion merged commit d22e033 into master Mar 28, 2020
@taion taion deleted the live-render branch March 28, 2020 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jquense jquense jquense approved these changes

@ethanve ethanve Awaiting requested review from ethanve

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@taion @jquense