Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency is-promise to v4 #688

Merged
merged 1 commit into from
Apr 28, 2020

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 28, 2020

This PR contains the following updates:

Package Type Update Change
is-promise dependencies major ^3.0.0 -> ^4.0.0

Release Notes

then/is-promise

v4.0.0

Compare Source

Breaking Changes

  • Use PromiseLike instead of Promise in TypeScript (#​40)

    This is only a breaking change for TypeScript users.

    In the following code:

    function foo(x: PromiseLike`string> | string) {
      if (isPromise(x)) {
        return x;
      } else {
        return Promise.resolve(x);
      }
    }

    TypeScript would previously have incorrectly inferred foo as returning Promisestring>when in fact it returnsPromiseLikestring>. The latest version fixes this. If you instead had the following code, it should work exactly the same as before:

    function foo(x: Promise`string> | string) {
      if (isPromise(x)) {
        return x;
      } else {
        return Promise.resolve(x);
      }
    }

    This update is to reflect the fact that is-promise does "duck" typing, rather than an instanceof check.


Renovate configuration

📅 Schedule: "before 2am" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@taion taion merged commit 4451e61 into master Apr 28, 2020
@taion taion deleted the renovate/is-promise-4.x branch April 28, 2020 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants