Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support status codes for redirects #717

Merged
merged 2 commits into from
Jul 24, 2020

Conversation

dzucconi
Copy link
Contributor

Seems like it would make sense to be able to also support an optional status code on the error.

My use-case here is wanting to have some server-side redirects be permanent (301) and being able to differentiate.

@taion
Copy link
Contributor

taion commented Jul 24, 2020

Good change! Let's add status?: number as the 2nd argument to RedirectException, default it to 302 there, then update the TS types accordingly?

@taion
Copy link
Contributor

taion commented Jul 24, 2020

@dzucconi dzucconi force-pushed the feat/support-status-in-redirect branch 2 times, most recently from 0ece0b7 to 20b4e65 Compare July 24, 2020 21:11
@dzucconi dzucconi force-pushed the feat/support-status-in-redirect branch from 20b4e65 to faa39c1 Compare July 24, 2020 21:13
@dzucconi
Copy link
Contributor Author

@taion 👍 updated

@taion
Copy link
Contributor

taion commented Jul 24, 2020

Pushed a little commit to add status support to <Redirect> as well, as a "why not" thing.

@taion taion merged commit 24c1a1e into 4Catalyzer:master Jul 24, 2020
@taion
Copy link
Contributor

taion commented Jul 24, 2020

published in v0.5.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants