Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Improve type definitions #726

Merged
merged 4 commits into from
Jul 31, 2020
Merged

feat: Improve type definitions #726

merged 4 commits into from
Jul 31, 2020

Conversation

taion
Copy link
Contributor

@taion taion commented Jul 31, 2020

No description provided.

@taion taion merged commit fa05456 into master Jul 31, 2020
@taion taion deleted the improve-types branch July 31, 2020 03:31
@ersinakinci
Copy link

@taion why was addNavigationListener removed from the interface for Router?

@taion
Copy link
Contributor Author

taion commented Nov 28, 2020

It's still there. It just comes in via Router extending FarceStoreExtension now: https://github.com/4Catalyzer/farce/blob/ed3048193d3f04afc53cd955fb8ef2eca37d0d95/types/index.d.ts#L129-L136

@ersinakinci
Copy link

Whoops! Thanks for pointing me in the right direction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@taion @ersinakinci