Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fortune Cookies? #4

Closed
teknowledgist opened this issue Oct 4, 2020 · 13 comments
Closed

Fortune Cookies? #4

teknowledgist opened this issue Oct 4, 2020 · 13 comments

Comments

@teknowledgist
Copy link

Thank you so much for rewriting Signature Switch for the new Thunderbird!

I see that you mention the ability to use fortune cookie files (like with the legacy SS), but I can't figure out how to do that. Is that feature still being developed/rewritten, or am I just missing the obvious?

Thanks.

@4ch1m
Copy link
Owner

4ch1m commented Oct 5, 2020

I haven't ported this feature yet. I'm also not quite sure how many people actually used fortune cookies in Signature Switch. So... everybody... please upvote this issue if I should prioritize working on this.

@jabrugger
Copy link

Yes please, re-add support for fortune cookies.
Thanks for your great work.

@emja
Copy link

emja commented Oct 9, 2020

Emphatic upvote for this one.

I rely on a signature dynamically generated by an external script, which inserts a unique URL based on the recipients' address.

@BernardOOO
Copy link

Thanks a lot for rewriting, i used SS for years ago and i hope you can add the fortunes cookies files asap. I really need that ;-)

@4ch1m
Copy link
Owner

4ch1m commented Oct 11, 2020

Implemented. ✔️
Beta-release available here: dev-builds

@emja
Copy link

emja commented Oct 11, 2020

Thanks. Installed. I see you've implemented an internal 'fortune cookie' function (which I don't use, so didn't test), however this version lacks the ability to read from an external file or to use the output of an external script (as older versions did). Is this a limitation in the new TB framework, or are you intending to re-implement that?

cheers!

@BernardOOO
Copy link

Fortune cookie feature installed. It works fine ! This addon is great . Thanks for your work.

@teknowledgist
Copy link
Author

Thank you for putting the time in to add this critical feature. That said, can you add a toggle to it to remove the signature? Currently, choosing the signature again adds a second, third, etc. one.

@4ch1m
Copy link
Owner

4ch1m commented Oct 12, 2020

@emja Signature Switch is a pure MailExtension now. So... access to files is limited. However, you can still import fc-files using the UI.

Closing this issue, since Fortune Cookie support is now available with version 2.1.0.

@4ch1m 4ch1m closed this as completed Oct 12, 2020
@4ch1m
Copy link
Owner

4ch1m commented Oct 12, 2020

@teknowledgist

That said, can you add a toggle to it to remove the signature? Currently, choosing the signature again adds a second, third, etc. one.

I'm not quite sure what you mean by that?!

@teknowledgist
Copy link
Author

In the earlier version, clicking on the icon would toggle the signature on and off. IOW, add or remove the (default?) signature from the draft message.

In my brief test, the current version just adds another quote below the first.

Also, choosing the particular signature would "refresh" the fortune cookie. That allowed me to bypass pithy signatures that might get me in trouble with certain recipients. This version does re-select a random cookie, but tacks it below the previous signature.

Neither is a major problem, just anno... less efficient. ;-)

@4ch1m
Copy link
Owner

4ch1m commented Oct 13, 2020

In the earlier version, clicking on the icon would toggle the signature on and off. IOW, add or remove the (default?) signature from the draft message.

Yep.
That's how it should work.
I haven't seen any issues with this so far. (No reports either... other than you. g)
Please let me know if you can still reproduce this.

Neither is a major problem, just anno... less efficient. ;-)

Well... if it is like you described... then we definitely have a bug 🪲 ... which should be squashed. 😄
Don't hesitate to contact me (via email).

@jabrugger
Copy link

Working as expected, THANKS A LOT!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants