Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration offizieller API #2

Closed
Azathoth88 opened this issue Sep 19, 2022 · 3 comments
Closed

Integration offizieller API #2

Azathoth88 opened this issue Sep 19, 2022 · 3 comments

Comments

@Azathoth88
Copy link

Achim klingt deutsch, daher bin ich mal so frei: Ich bin jetzt durch Zufall auf deine Swagger-Integration gestoßen... Super Sache - danke dafür! Nun zum Thema:

Unter http://doc.divoom-gz.com/web/#/12?page_id=89 steht eine offizielle API-Beschreibung zur Verfügung. Vielleicht sind da noch unentdeckte Funktionen vorhanden.
Spannend dürfte hier insbesondere der Find device command sein. Vielleicht könnte man sich damit die Angabe des PIXOO_HOST sparen und automatisiert im Netzwerk nach dem Gerät suchen?

@4ch1m
Copy link
Owner

4ch1m commented Sep 20, 2022

Achim klingt deutsch, daher bin ich mal so frei:

In the interest of the worldwide GitHub-community, english should be the preferred language here.

Unter http://doc.divoom-gz.com/web/#/12?page_id=89 steht eine offizielle API-Beschreibung zur Verfügung. Vielleicht sind da noch unentdeckte Funktionen vorhanden. Spannend dürfte hier insbesondere der Find device command sein. Vielleicht könnte man sich damit die Angabe des PIXOO_HOST sparen und automatisiert im Netzwerk nach dem Gerät suchen?

I'm aware of this API-documentation and the "Find Device" command.
However, I'm not sure how that should be utilized in this context.
In order to talk to a device and/or send an API-request you'll need to have an (IP-)address or hostname.
I'm sure this command could be used to find additional Pixoo-devices in the same network.
But i guess the initial request has to be made using a specific address.

But improvements are always welcome.
I'll gladly review your pull-request and merge it; if it works.

Closing, since this is not actually an issue.

@4ch1m 4ch1m closed this as completed Sep 20, 2022
@Azathoth88
Copy link
Author

Hello Achim,
I am not a developer, but in a professional context I am a product owner. So I understand something about requirements management and roughly something about interfaces. However, I can't program that myself. I didn't know if you know the API, so this is just a friendly hint. If there are no adjustments, that's fine too. The API works.

@4ch1m
Copy link
Owner

4ch1m commented Sep 20, 2022

No offense. No worries. Just wanted to point out that this is a non-commercial and open-source hobby-project. Any contributions are very welcome. Based on your comment I personally just don't see any concrete possibilities for useful/additional implementations here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants