Chat messages are getting duplicated

[ghost]

Hello there, i am currently using a plugin that is dependent on SignedVelocity. I'm encountering an issue that is not present when i used to use UnSignedVelocity, that causes all chat messages to be duplicated twice on my servers.

My environment :
HuskChat 2.7.1
SignedVelocity 1.1.0
Velocity Build 276

I have talked with the developer of HuskChat and made sure this was not a configuration issue on my side.

[thewilloftheshadow]

I'm also experiencing this issue using the same versions of all plugins

[4drian3d]

I have been trying to reproduce the bug for a long time and I have only been able to replicate it once and only in a Paper based environment

[ghost]

This bug suddenly starts and stops in my experience. After a period of all messages duplicated it may pause until some time, or until the server is restarted to come back and duplicate messages again.

[Athar42]

Hi there :)

I'm also experiencing the same behavior.
HuskChat send "Unsigned" messages, and the duplicated messages are local message (from the server where we typed it) and seems to be signed.

Plugins versions on my side :
PROXY :
Velocity 3.2.0-SNAPSHOT (git-81b183ac-b276)
vpacketevents 1.1.0 by 4drian3d
signedvelocity 1.1.0 by 4drian3d
huskchat 2.7.1 by William278

LOBBY :
Paper version git-Paper-550 (MC: 1.19.4) (with DeluxeHub)
SignedVelocity Paper 1.1.0

All other servers :
Paper version git-Paper-41 (MC: 1.20.1) (had to stick on that version, since starting release 43, I had issues with other plugins not working. May need to check if this is fix with latest build of this branch (so build 155) Will make an update here if this change anything but I highly doubt it will, since with Paper 1.19.4 (Lobby) the issue exist too)
SignedVelocity Paper 1.1.0

I don't know what I can do more to help tackle down this issue (any debug stuff we can enable ? @4drian3d )

Also : Like rktfier said, with Unsigned Velocity, it was working fine (untill I update everything on the proxy to support 1.20.2 clients with viaversion/viabackwards).

[ghost]

I was able to change back to UnsignedVelocity and it seems to work fine as a temporary solution until SignedVelocity is fixed. It still causes player disconnects, but much better than duplicated messages at random times.

[4drian3d]

Can you test this version? https://github.com/4drian3d/SignedVelocity/actions/runs/6738914306 I have rewritten the SignedVelocity Backend logic and have not been able to reproduce the bug again.
The debug mode is enabled by default in this build so you can report if for some reason the bug reappears

[Athar42]

On my way to the test ground :p

[Athar42]

I think we can say it's a Yes !

Tested in the lobby (1.19.4 / two first screens) then in a survival server (1.20.1), seems all good.

From the console, everything looks fine :)

[00:28:15 INFO]: [SignedVelocity] [DEBUG] [CHAT] Result applied
[00:28:15 INFO]: [SignedVelocity] [DEBUG] [Plugin Message] Received Valid Message
[00:28:15 INFO]: [SignedVelocity] [DEBUG] | Queue: CHAT_RESULT
[00:28:15 INFO]: [SignedVelocity] [DEBUG] | Result: CANCEL
[00:28:15 INFO]: [SignedVelocity] [DEBUG] | Message: null
[00:28:16 INFO]: [SignedVelocity] [DEBUG] [Plugin Message] Received Valid Message
[00:28:16 INFO]: [SignedVelocity] [DEBUG] | Queue: CHAT_RESULT
[00:28:16 INFO]: [SignedVelocity] [DEBUG] | Result: CANCEL
[00:28:16 INFO]: [SignedVelocity] [DEBUG] | Message: null
[00:28:16 INFO]: [SignedVelocity] [DEBUG] [CHAT] Init Message Handling
[00:28:16 INFO]: [SignedVelocity] [DEBUG] [CHAT] Queueing Next Result
[00:28:16 INFO]: [SignedVelocity] [DEBUG] [CHAT] Future Done: true
[00:28:16 INFO]: [SignedVelocity] [DEBUG] [CHAT] Waiting for next result
[00:28:16 INFO]: [SignedVelocity] [DEBUG] [CHAT] Next Result
[00:28:16 INFO]: [SignedVelocity] [DEBUG] [CHAT] Cancelled Message.
[00:28:16 INFO]: [SignedVelocity] [DEBUG] Original Message: t
[00:28:16 INFO]: [SignedVelocity] [DEBUG] [CHAT] Result applied
[00:28:16 INFO]: [SignedVelocity] [DEBUG] [Plugin Message] Received Valid Message
[00:28:16 INFO]: [SignedVelocity] [DEBUG] | Queue: CHAT_RESULT
[00:28:16 INFO]: [SignedVelocity] [DEBUG] | Result: CANCEL
[00:28:16 INFO]: [SignedVelocity] [DEBUG] | Message: null
[00:28:16 INFO]: [SignedVelocity] [DEBUG] [CHAT] Init Message Handling
[00:28:16 INFO]: [SignedVelocity] [DEBUG] [CHAT] Queueing Next Result
[00:28:16 INFO]: [SignedVelocity] [DEBUG] [CHAT] Future Done: true
[00:28:16 INFO]: [SignedVelocity] [DEBUG] [CHAT] Waiting for next result
[00:28:16 INFO]: [SignedVelocity] [DEBUG] [CHAT] Next Result
[00:28:16 INFO]: [SignedVelocity] [DEBUG] [CHAT] Cancelled Message.
[00:28:16 INFO]: [SignedVelocity] [DEBUG] Original Message: t
[00:28:16 INFO]: [SignedVelocity] [DEBUG] [CHAT] Result applied

[4drian3d]

Thank you very much for testing it, I will wait until early tomorrow morning to release the new release in case someone else can confirm it in another setup

[Athar42]

For now, all my servers are updated using it, I spammed the t'chat and no errors so far (well, until the final release, I'll have to not look at the console 🤣).

Nice work and thanks for your time on that plugin !

[Athar42]

Argh, not really the place to post that, but I tried to give you some little extra with the sponsor program on Git, but I don't really want to put my card details on this platform (and they disabled the use of Paypal sadly).
If you use any other platform where I can give you some bucks, I'll be more than happy ;)

nvm : found it on Modrinth ;)

[4drian3d]

I do have the one-time sponsor enabled, but I also have PayPal https://paypal.me/4drian3d if you can't use GitHub Sponsors

[Athar42]

Yeah, the "one-time issue" was my fault, Adblock (don't know why, but it blocked the check).

One question, what's the difference between vPacketEvents and PacketEvents (as you develop both) ?
Also, I know the first one only need to be placed in the proxy, is this the case with PacketEvents too ?

Edit : Just in case, in your profile on Github, you did setup a link to twitter : It's redirect to a non-existing account 😉

[4drian3d]

VPacketEvents was a plugin I made because at that time PacketEvents did not exist. Both work with SignedVelocity but are optional dependencies and require them to be installed in Velocity. And just in case, I have a Discord server for support and to discuss other topics, this is already getting out of focus and every message is emailed to every member of the conversation 😅