Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding react v18 to peerDependencies #31

Closed
scraggo opened this issue Oct 7, 2022 · 3 comments
Closed

Consider adding react v18 to peerDependencies #31

scraggo opened this issue Oct 7, 2022 · 3 comments

Comments

@scraggo
Copy link

scraggo commented Oct 7, 2022

react v18 isn't included in the list of peerDependencies.

Haven't fully tested, but it's working after using it in a newly installed create-react-app which uses react@18.2.0.

Not a blocking issue, but I need to use a workaround like --legacy-peer-deps in order to use the packages.

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: react-guitar@1.1.1
npm ERR! Found: react@18.2.0
npm ERR! node_modules/react

...

npm ERR! Could not resolve dependency:
npm ERR! peer react@"^16.8 || ^17.0" from react-guitar@1.1.1
npm ERR! node_modules/react-guitar
npm ERR!   react-guitar@"^1.1.1" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: react@17.0.2
npm ERR! node_modules/react
npm ERR!   peer react@"^16.8 || ^17.0" from react-guitar@1.1.1
npm ERR!   node_modules/react-guitar
npm ERR!     react-guitar@"^1.1.1" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

If I can help, let me know.

Thank you for considering this.

@4lejandrito
Copy link
Owner

Thanks @scraggo! I'll do during the weekend.

@4lejandrito
Copy link
Owner

Done! Published as 1.1.2.

@scraggo
Copy link
Author

scraggo commented Oct 14, 2022

Works great! Thanks for doing this so quickly 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants