Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable window column pruning optimization in openmldb-batch #939

Open
tobegit3hub opened this issue Dec 21, 2021 · 3 comments
Open

Enable window column pruning optimization in openmldb-batch #939

tobegit3hub opened this issue Dec 21, 2021 · 3 comments
Assignees
Labels
batch-engine openmldb batch(offline) engine enhancement New feature or request

Comments

@tobegit3hub
Copy link
Collaborator

Now we need to add new config for openmldb-batch and set for window column purning optimization.

@tobegit3hub tobegit3hub added the enhancement New feature or request label Dec 21, 2021
@tobegit3hub tobegit3hub added this to the v0.4 milestone Dec 21, 2021
@tobegit3hub tobegit3hub self-assigned this Dec 21, 2021
@tobegit3hub tobegit3hub added this to To do in OpenMLDB Batch via automation Dec 21, 2021
@tobegit3hub
Copy link
Collaborator Author

The new config enable_window_column_pruning is defined in sql_compiler.h. We should add the new config like enable_batch_window_parallelization and enable by users config.

struct SqlContext {
    // mode: batch|request|batch request
    ::hybridse::vm::EngineMode engine_mode;
    bool is_cluster_optimized = false;
    bool is_batch_request_optimized = false;
    bool enable_expr_optimize = false;
    bool enable_batch_window_parallelization = true;
    bool enable_window_column_pruning = false;

......

@dl239 dl239 modified the milestones: v0.4, v0.5 Dec 27, 2021
@tobegit3hub tobegit3hub modified the milestones: v0.5, v0.6 May 7, 2022
@tobegit3hub tobegit3hub removed this from the v0.6 milestone Jun 16, 2022
@tobegit3hub tobegit3hub changed the title Enable window column purning optimization in openmldb-batch Enable window column pruning optimization in openmldb-batch Jun 21, 2022
@lumianph lumianph added the batch-engine openmldb batch(offline) engine label Jun 29, 2022
@pearfl
Copy link
Contributor

pearfl commented Aug 27, 2022

Please assign this task to me

@lumianph
Copy link
Collaborator

lumianph commented Aug 29, 2022

looking forward to your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
batch-engine openmldb batch(offline) engine enhancement New feature or request
Projects
Development

No branches or pull requests

4 participants