UI issues in color select #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -25,7 +25,7 @@ dependencies: | |||
| # The following adds the Cupertino Icons font to your application. | |||
| # Use with the CupertinoIcons class for iOS style icons. | |||
| cupertino_icons: ^0.1.3 | |||
| flutter_svg: 0.17.1 | |||
| flutter_svg: ^0.17.3+1 | |||
There was a problem hiding this comment.
|
Can you set padding for the whole list in a way that it will not crop circles with color, please? As for me, it seems strange to see blank white space and crop |
|
Or another option - use Wrap instead of Row. I think it can be good too |
done
|
|
Thank you, Vladislav! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like items of color are more than space.
So obviously approach is to wrap into
SingleChildScrollViewIt was
It now
MacOS Catalina 10.15.3
Flutter 1.15.22-pre.24
Simulator iPhone 8