Skip to content
This repository has been archived by the owner on Nov 25, 2019. It is now read-only.

Zero-Downtime broken when updating startsecs #21

Open
jone opened this issue Nov 9, 2018 · 0 comments
Open

Zero-Downtime broken when updating startsecs #21

jone opened this issue Nov 9, 2018 · 0 comments

Comments

@jone
Copy link
Member

jone commented Nov 9, 2018

When an upgrade is deployed, where zero-downtime is active and the supervisor startsecs are changed in the update, the instances are restarted in parallel, but should be restarted serially (since zero-downtime active).

Suspicion:

The script does a bin/supervisorctl update instance1, while instance1 is stopped. When there is no change, nothing happens. But when there is a change in the supervisor config, the new config is loaded an the autostart-setting will cause the instance to be started.
The problem is that supervisor now starts the instance but this is not blocking and the next start instance1 command will be instantly terminated since the instance is already starting. Normally start instance1 would block for startsecs time, so that the instances are properly restarted serially.

This probably needs to be fixed in supervisor.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant