Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State's :Observe callback should pass the new value first, old value last. #4

Closed
4x8Matrix opened this issue Feb 27, 2024 · 0 comments

Comments

@4x8Matrix
Copy link
Owner

Context

State's `:Observe' functionality is inherited from Comm, however the arguments passed in aren't accurate, Comm only passes in the new value, and no old value kept.

This ticket proposes changes that enable State to pass the new value first, and then the old value, so keeping the API similar to comm.

4x8Matrix added a commit that referenced this issue Mar 8, 2024
ISSUE-4: swap 'value' with 'oldValue'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant