Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for navigationController #13

Closed
Alex293 opened this issue Sep 24, 2016 · 5 comments
Closed

Support for navigationController #13

Alex293 opened this issue Sep 24, 2016 · 5 comments

Comments

@Alex293
Copy link

Alex293 commented Sep 24, 2016

Hi,

As you recommended to not inherit from pulleyViewController directly how should we react for navigation controller bar button items ?

I'm gonna start by using buttons but I think its something useful

@amyleecodes
Copy link
Contributor

You shouldn't put the pulley drawer inside a navigation controller. It was intended to be a parent VC only, like Apple's Maps app.

If you need to put it in a navigation controller (really not recommended from a UI / UX perspective) then you can just directly assign bar button items to the pulley drawer controller's navigationItem property.

@amyleecodes
Copy link
Contributor

Also: You're welcome to try subclassing it, but it's not a scenario in going to provide explicit support for.

@Alex293
Copy link
Author

Alex293 commented Sep 24, 2016

You were right anyway one the UI/UX points, just wanted to use a transparent bar to keep only the bar buttons so if I open a new vc I have the back button for free.

@amyleecodes
Copy link
Contributor

I would try subclassing it, or just assign bar buttons to the navigationItem of the existing one.

@Alex293
Copy link
Author

Alex293 commented Sep 24, 2016

OK thank you for your advices ! Closing this

@Alex293 Alex293 closed this as completed Sep 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants