Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dApp Integration - extension #23

Closed
tschubotz opened this issue Nov 9, 2018 · 1 comment
Closed

dApp Integration - extension #23

tschubotz opened this issue Nov 9, 2018 · 1 comment

Comments

@tschubotz
Copy link
Member

Story
As a user I am able to use the Gnosis Safe with dApps on my browser so I can make use of my funds.

Background

  • There is EIP-1102.
  • Metamask is used by pretty much everyone, but the current Web3Provider standards don't account for multiple providers.
  • There are dApps that would like to specifically with the Safe (at least slow.trade, Olympia).
  • The current "hacky" overwrite solution is not 100% reliable.

Acceptance criteria

  • There are 2 ways, the dApps could be integrate with the Safe extension:

Way 1: Communicate with extension via injected Web3Provider

  • If no other provider installed:
    • If website not whitelisted: do nothing
    • If website is whitelisted: inject (EIP-1102)
  • If other provider installed
    • Display info/error message to the user that there is another one and that will cause problems. (Same like Metamask)
      • How will this message be displayed? Console first, some other UI perhaps later

Way 2: Communicate with extension via channel other than the injected provider

  • For dApps that want to integrate specifically with the Safe, no matter if the user has a Safe or not.
  • Still respect whitelisting toggle, i.e. only allow communication when site (dApp) is whitelisted.

→ The Safe extension will only be usable, (1) if there is no other provider available or (2) if the dApp specifically integrates with it via some kind of library.

@tschubotz
Copy link
Member Author

We intend to integrate with WalletConnect 👉 closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant