Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue Detail doesn't always show Contacts after setting Zipcode #53

Closed
mccarron opened this issue Feb 10, 2017 · 5 comments
Closed

Issue Detail doesn't always show Contacts after setting Zipcode #53

mccarron opened this issue Feb 10, 2017 · 5 comments
Milestone

Comments

@mccarron
Copy link
Collaborator

On a fresh install sometimes the Issues Detail screen doesn't show the contacts after setting the location from the Issues Detail screen.

I don't think this bug needs to be fixed for 1.0 as I can't reproduce it reliably.

Partial Steps To Reproduce:

  1. Delete app and install fresh
  2. Launch app and get through tutorial
  3. Open random issue
  4. Scroll to bottom to touch the "Set your location..." red text to open the Location Edit screen
  5. Enter a zip code and hit SUBMIT

Instead of your Reps you'll sometimes see the "Set your location..." text again.

To get this I did Steps 3 & 4 a few times but exiting the location screen before actually entering it and got it to reproduce. May be related to that sequence.

@mccarron mccarron added this to the 1.1 milestone Feb 10, 2017
@jablair
Copy link

jablair commented Feb 10, 2017

I'm seeing this now. Let me know if there's anything I can do to collect some info for you.

@mccarron
Copy link
Collaborator Author

After a deeper dive this AM I agree with @nickoneill that this is a Split District issue actually. We just need to handle zip being set and getting no contacts and instead show text to ask for a more specific address.

@subdigital
Copy link
Collaborator

Quick implementation idea:

  • check issuesList response, it has a splitDistrict value of `true.

If a split district is detected, prompt the user to use their location instead.

Long term we may want to allow users adding their full address, but I think the above is a quick solution.

@bengottlieb
Copy link
Contributor

I just put up a pull request to address this.

@subdigital
Copy link
Collaborator

Implemented by #58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants