Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Data? #103

Closed
cjo1pal opened this issue Oct 25, 2019 · 10 comments
Closed

New Data? #103

cjo1pal opened this issue Oct 25, 2019 · 10 comments

Comments

@cjo1pal
Copy link
Contributor

cjo1pal commented Oct 25, 2019

There is a lot of other data for monster, classes, races, etc. for dnd.
Are you planning on adding this data to database?
Would it be ok if I submitted pull requests for new data added?
-------I know it won't work with the API, but at least it can be in the database

@ogregoire
Copy link
Collaborator

ogregoire commented Oct 25, 2019

What data are you speaking about? Everything published in Volo's Guide to Monsters for instance? Or Xhanatar's Guide to Everything?

Those are books that contain proprietary content. This repo provides the SRD in a convenient format. The SRD is a part of D&D that is freely (as in free speech) available to everyone, so this repo was made on that assumption. Adding new faces monsters and such that aren't present in the SRD cannot be done if the data comes from proprietary sources such as D&D books.

So, no, it would not be OK to add that data.

@JonesiBlitz
Copy link

Free speech? Hahaha

@benjaminapetersen
Copy link

Agree, this should stay strictly SRD for all kinds of copyright reasons.

On that, anyone know where the original data came from? I'm how these JSON files were first generated.

@bagelbits
Copy link
Collaborator

You'd have to ask @adrpadua, though they are difficulty to get a hold of.

@benjaminapetersen
Copy link

Not sure if he is still interested in owning this repo, or if the "primary" status could be moved to someone more actively maintaining (@bagelbits& @ogregoire seem reasonable candidates as the majority of recent PRs are theirs)

@bagelbits
Copy link
Collaborator

I'll ask him.

@bagelbits
Copy link
Collaborator

So sounds like I might be getting the API and database repos transferred to me. However, this also means that the current API is going to be taken down and I'll have to host the site myself.

@benjaminapetersen
Copy link

I don't know if there is anyone depending on the current running site or if that matters.

I imagine it would self-host via github pages, its all front-end files at this point. Just thinking out loud.

@bagelbits
Copy link
Collaborator

I'm going to see if there is any traffic running on the page. But spinning up my own version shouldn't be too bad. Especially if I snag the domain as well.

@bagelbits
Copy link
Collaborator

Closing since both repos have been transferred.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants