Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow failling the check without failling to step. #63

Open
gpoulin-hopper opened this issue Dec 13, 2021 · 0 comments
Open

Allow failling the check without failling to step. #63

gpoulin-hopper opened this issue Dec 13, 2021 · 0 comments

Comments

@gpoulin-hopper
Copy link

Currently if fail_below_threshold is true and the threshold, both the step and the coverage check would be marked as failed. Ideally only the check would be marked as failed since it allows to easily that the job was able to succeed, but the coverage was insufficient. To avoid changing the current behaviour, an input could be added to get the described behaviour.

A workaround is to set continue-on-error: true. However this solution will also mark the job as success even if we were unsuccessful at creating the coverage report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant