Added tests to show errors in django 1.10 #37
Conversation
(Updated travis)
|
Ah this is perhaps why in a brand new model with EnumFIeld... .save() blows up without a force_insert=True.... |
…hon3.3 (cherry picked from commit 9a2fbb3)
|
@listingmirror I beileve so --- I also got exception on
This might be a bug in Django, but it is triggered by If you need a working version: here is a version that works: https://github.com/i2biz/django-enumfield/tree/jbzdak/django110 (but please check the tests as some tests needed to be skipped due to changes I had to make). |
|
@jbzdak Based on no issues in Django issue tracker around save, and this is the only plugin breaking like this, I am going to make the claim the bug is here not in Django. With that said, what is the right thing to do? I can spare some cycles to put together a PR.. but also debating just ripping this plugin out and doing something else. I don't personally care about any of the state transition stuff, just want a simple way to store enums without a separate database table to join to. |
|
@listingmirror I wouldn't be so sure - found at least one other project affected: jpwatts/django-positions#49 (I'm with you on feeling like ripping this out though) |
…ure/2.0 * origin/forks/fcurella/enum34: Fix for issue mentioned in 5monkeys#37 Run tests against Django 1.9+ Define default value explicitly via __default__ attribute Support `--failfast` argument in run_tests Add changelog section to readme subclass IntEnum instead of Enum Fix hashing enum Test model initialization more precisely for different Django versions Use SubfieldBase for Django < 1.8 Drop Django 1.5 support Change labels and transitions attr name; use... enum instead of int in field value; raise validation error when enum is not found by value or name (and support digit str), etc Update test config Add `.deconstruct()` for Django migrations Fix labels by renaming the attribute to `_labels` Use enum34 class # Conflicts: # .travis.yml # Makefile # README.rst # django_enumfield/db/fields.py # run_tests.py # tox.ini
Adding this PR to show bug in
django-enumfieldin the newly releasedDjango==1.10.Problem was (most probably) caused by this changeset in Django repository: django/django@7f51876, and especially by the change to
get_deferred_fields.Let's consider this model:
EnumFieldusers Python properties under the hood, that is:Person.statusis a property, this causes check used byget_deferred_fieldsto always treatstatusas a deffered field (that is always"status" not in self.__dict__). This causes all kinds of fun, for example excludes status from fields that are updated.