Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is root-tag <RequestSecurityTokenResponseCollection> really necessary? #4

Open
doeringp opened this issue Nov 23, 2020 · 2 comments
Open

Comments

@doeringp
Copy link

doeringp commented Nov 23, 2020

I opened this issue for discussion. Look at this TODO comment in code.

In my opinion wrapping the <RequestSecurityTokenResponse> in a <RequestSecurityTokenReponseCollection> isn't necessary.

The old sample IdentityServer/IdentityServer4.WsFederation running on .NET Framework, does not do it either.

I've tested it on SharePoint. It did work without the collection:
image
image

@doeringp doeringp changed the title Is <RequestSecurityTokenResponse> really necessary? Is <RequestSecurityTokenResponseCollection> really necessary? Nov 23, 2020
@doeringp doeringp changed the title Is <RequestSecurityTokenResponseCollection> really necessary? Is root-tag <RequestSecurityTokenResponseCollection> really necessary? Nov 23, 2020
@doeringp
Copy link
Author

ADFS also does not wrap the RequestSecurityTokenResponse in a collection.

@616b2f
Copy link
Owner

616b2f commented Feb 9, 2022

You are right we could omit it to be better compatible (more ADFS like). PR's are welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants