Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention to ignore generated files on .gitignore and analysis_options.yaml #5

Closed
SaeedMasoumi opened this issue Aug 28, 2021 · 4 comments
Closed

Mention to ignore generated files on .gitignore and analysis_options.yaml #5

SaeedMasoumi opened this issue Aug 28, 2021 · 4 comments

Comments

@SaeedMasoumi
Copy link
Contributor

It is worth mentioning to exclude generated files in the README.md:

For .gitignore:

*.sealed.dart

For analysis_options.yaml

analyzer:
  exclude:
    - **.sealed.dart
@FatulM
Copy link
Contributor

FatulM commented Aug 29, 2021

Hi,
I think it should be added to our convention repository !?
And I don't think excluding files from analyzer is a good idea.

@SaeedMasoumi
Copy link
Contributor Author

SaeedMasoumi commented Aug 29, 2021 •
edited
Loading

No for general use.
What is the point of analyzing generated code?

Also, this kind of documentation is a suggestion to let users know how they can do that.

@FatulM
Copy link
Contributor

FatulM commented Aug 29, 2021

Ok
I'll add this for next release

@FatulM
Copy link
Contributor

FatulM commented Aug 31, 2021

I've added this to master branch documentation,
It will be published with next version

@FatulM FatulM closed this as completed Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SaeedMasoumi @FatulM