Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: minify #24

Merged
merged 1 commit into from Sep 9, 2016
Merged

Feature: minify #24

merged 1 commit into from Sep 9, 2016

Conversation

marcobiedermann
Copy link
Contributor

Replace gulp-cssmin with gulp-clean-css to improve maintenance:

gulp-cssmin

Duplicate of gulp-minify-css

Source

gulp-minify-css

This package has been deprecated. Please use gulp-clean-css instead.

Source

@45kb
Copy link
Member

45kb commented Sep 9, 2016

Hi, thanks for the support, did you try to run gulp build to see if the dist/ minified files are ok, after all the tasks have finished?

I ask this, only because, i remember i had bad days with that specific minifier module...but, actually, i could mistake... let me know or i will anyway give it a try

@marcobiedermann
Copy link
Contributor Author

@45kb
Yes, I've checked it. Everything looks exactly the same. Only changed the date, so I refused to commit them :)

@45kb
Copy link
Member

45kb commented Sep 9, 2016

Awesome, thanks a lot!

@45kb 45kb merged commit 9e5a47f into 720kb:master Sep 9, 2016
@marcobiedermann
Copy link
Contributor Author

@45kb You are very welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants