Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kanban Board Setup #34

Open
78fatemanazari opened this issue Nov 14, 2023 · 3 comments
Open

Kanban Board Setup #34

78fatemanazari opened this issue Nov 14, 2023 · 3 comments

Comments

@78fatemanazari
Copy link
Owner

Github Project Link:

We are 4 collaborating in this capstone project(Here are the Github links):

@danmainah
Copy link

Hi @78fatemanazari , @GhausAliKhan , @Rafiduzzaman and @CobbyElsonfx ,

Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

Required Changes ♻️

  • @Team kindly move every task to its own card, on the cards shown in the screenshot below, this is part of the project requirement as shown below:
    image

image
image
image
image
image
image
image
image
image

  • @Team after implementing the changes above, kindly consider ensuring all tasks have be allocated point fairly, eg class creation should have same points in all classes or similar structured classes, also esnure fair distribution of group work to all members.

Optional suggestions

  • @Team although you have listed each team member it would be better if you made it more clear eg instead of MR. FRANCIS ANDOH: https://github.com/CobbyElsonfx (Team member https://github.com/78fatemanazari/ruby-capstone/issues/3) it should be MR. FRANCIS ANDOH: https://github.com/CobbyElsonfx (Team member 3)

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


_As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@1GORDON
Copy link

1GORDON commented Nov 14, 2023

Hi team✋

Good job so far!

Highlights!

  • Implemented requested changes ✔️

Hello ✋, you have done well reaching this point of the milestone 🤝 . But there are some issues that you still need to work on to go to the next project but you are almost there!

Status: Required Changes ♻️⛔️

  • As requested by the previous reviewer, kindly ensure fair distribution of group work to all members. You may assign the 4th member to the group task.
    group

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend considering them as they can improve your code.

Cheers, and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread and tag me @1GORDON if something is not 100% clear.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think the code review was unfair, request a second opinion using this form.

@KanzaTahreem
Copy link

Approved 🙌

Hi @78fatemanazari , @GhausAliKhan , @Rafiduzzaman &@CobbyElsonfx ,

Good job implementing thee suggested changes 💪 Your project is COMPLETE! You can start working on your project🚀 Congratulations!

Highlights 🎯

There are some excellent points that you have made perfectly. Keep up the great work! 👏

  • ✅ Implemented suggested changes
  • ✅ Difference b/w the points is less than 5
  • ✅ 4th member is assigned to the group task

Optional suggestions ❕

N/A

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👨‍💻💻

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants