Make ThemeProvider singleton using Hilt #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 6, 2021 00:20
- ThemeProvider 싱글턴 - Settings 모듈에서 Shared 모듈의 리소스를 직접 참조하는 대신 상수값 참조하도록 변경
- Hilt 를 이용하여 ThemeProvider 싱글턴 제공 - theme 설정 시점 Activity->Application - Activity.onCreate 에서 수행 시 uiMode 값 변경에 따라 Activity 새로 생성 됨 - Application 에 해당 로직을 넣어 Activity 두 번 생성되지 않게 적용 가능 TODO: 다크 모드로 앱 설정 해놓고 시스템은 light 일 때 앱 종료 상태에서 진입 할 때 white 윈도우 보여졌다가 뒤늦게 바뀌는 이슈
7loro
added
enhancement
|
#25 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Activity.onCreate 에서 수행 시 uiMode 값 변경에 따라 Activity 새로 생성 됨
- Application 에 해당 로직을 넣어 Activity 두 번 생성되지 않게 적용 가능
TODO: 다크 모드로 앱 설정, 시스템은 light 일 때 앱 종료 상태에서 진입 시 white 윈도우 보여졌다가 뒤늦게 바뀌는 이슈