Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually selected icon stays after icon pack uninstalled #1322

Closed
KrzysztofKozlowski opened this issue Jun 19, 2020 · 4 comments
Closed

Manually selected icon stays after icon pack uninstalled #1322

KrzysztofKozlowski opened this issue Jun 19, 2020 · 4 comments
Labels
bug Something isn't working in progress / implemented Already implemented/fixed or currently in the works and an update will be published soon.

Comments

@KrzysztofKozlowski
Copy link

KrzysztofKozlowski commented Jun 19, 2020

Is your feature request related to a problem? Please describe.
I know that this issue is not essential, but nevertheless it's something that doesn't work as it should, in my opinion. When you uninstall currently active icon pack, all icons that were set automatically are changed to their default versions. However, the ones that you set up manually stay the same. If it was your only icon pack, you are stuck and unable to change them back to default. When you try to edit the icon you get a message saying that you need an icon pack. The only solution is to install any icon pack, change icons to default manually or choose default icons in Look menu and then unistall it back.

Potentially connected to #830 (?)

Describe the solution you'd like
I think that option to reset icon to default should be accessible regardless of icon pack being installed or not. Just a button saying "Reset to defult" together with prompt that links to Play Store. I don't think it should be especially hard to implement since the functionality is already there.

In the end I would like to state that I absolutely love using Niagra Launcher and really appreciate all your work dedicated to making it better and better.

Kind regards,
Krzysztof

@Rod911 Rod911 added the duplicate This issue already exists label Jun 19, 2020
@Rod911
Copy link
Collaborator

Rod911 commented Jun 19, 2020

Duplicate of #553

@Rod911 Rod911 marked this as a duplicate of #553 Jun 19, 2020
@Rod911 Rod911 closed this as completed Jun 19, 2020
@KrzysztofKozlowski
Copy link
Author

Maybe I didn't say what was on my mind correctly, but I don't see how is my issue duplicate of #553 since in there you:

  1. Install icon pack.
  2. Apply icon pack.
  3. Want to change one of the automatically changed icons back to default and can't do that.

And in my case:

  1. Install icon pack.
  2. Apply icon pack.
  3. Change one of the icons your icon pack was missing manually to something similar from icon pack.
  4. Want to get rid of an icon pack (it bored you or something) and uninstall it.
  5. All icons change back to default except the one you have changed manually. It seems natural since you don't want to use this icon pack anymore that it should revert to default as well.
  6. If you don't have any other icon pack installed you can't revert this one icon back to default manually because Niagra wants you to install one. In the end most icons are default and you are stuck with one icon from pack that you don't want to use anymore.

Or is the solution for the other issue so similar that it would resolve this one as well? In that case sorry for taking up your time. All the best!

@8bitPit 8bitPit reopened this Sep 3, 2020
@8bitPit 8bitPit added bug Something isn't working and removed duplicate This issue already exists labels Sep 3, 2020
@8bitPit
Copy link
Owner

8bitPit commented Sep 3, 2020

That's a bug then, thank you very much for the detailed explanation :)

@8bitPit 8bitPit changed the title Reset icon to default without icon pack installed Manually selected icon stays after icon pack uninstalled Dec 22, 2020
@Maxr1998 Maxr1998 added the in progress / implemented Already implemented/fixed or currently in the works and an update will be published soon. label Nov 21, 2021
@8bitPit
Copy link
Owner

8bitPit commented Dec 15, 2021

Fixed in v.1.5

@8bitPit 8bitPit closed this as completed Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working in progress / implemented Already implemented/fixed or currently in the works and an update will be published soon.
Projects
None yet
Development

No branches or pull requests

4 participants