Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work Apps installed in the work profile don't show up unless i have the same app also installed in the non-work profile #2219

Closed
Neon-44 opened this issue Mar 12, 2023 · 10 comments
Assignees
Labels
bug Something isn't working in progress / implemented Already implemented/fixed or currently in the works and an update will be published soon.

Comments

@Neon-44
Copy link

Neon-44 commented Mar 12, 2023

Describe the bug

  1. make Work Profile via Shelter
  2. install MS Teams into work profile
  3. MS Teams doesn't show up in Niagara Launcher
  4. install MS Teams in non-work profile
  5. both MS Teams versions show up in Launcher

Steps to reproduce

  1. make Work Profile via Shelter
  2. install MS Teams into work profile
  3. MS Teams doesn't show up in Niagara Launcher
  4. install MS Teams in non-work profile
  5. both MS Teams versions show up in Launcher

Does the issue also occur with other 3rd-party launchers?

Problem doesn't occur with other launchers

Other 3rd-party launcher(s) tested

Lawnchair (F-Droid version and Play Store version), GrapheneOS Launcher, Neo Launcher

Device name

Google Pixel 7 Pro

Android version

Android 13

Screenshots / Screen recordings

No response

@Neon-44 Neon-44 added the bug Something isn't working label Mar 12, 2023
@Amorphous404
Copy link

Hi @Neon-44 , Thank you for bringing this to our attention. Can you please specify the version of Niagara that you are currently using?

Niagara settings -> Advanced -> App info

@Neon-44
Copy link
Author

Neon-44 commented Mar 13, 2023

My installed App Version is 1.8.15.

It should be the latest one i think.

@Amorphous404
Copy link

Amorphous404 commented Mar 13, 2023

Thank you for providing the information. I've forwarded the issue to our dev team.

@Amorphous404 Amorphous404 assigned 8bitPit and unassigned Amorphous404 Mar 13, 2023
@8bitPit
Copy link
Owner

8bitPit commented Mar 14, 2023

Thanks for reporting, @Neon-44. We received very similar bug reports a few months ago and rolled out a fix. This time, I can't reproduce it (I'm using Test DPC for managing the work profile). Can you reliably reproduce it? Moreover, does restarting Niagara Launcher help?

@Neon-44
Copy link
Author

Neon-44 commented Mar 14, 2023

Restarting doesn't help at all. Even rebooted the phone.

I am using shelter on Grapheneos on a pixel7P with sandboxed google play.

Reproducable 100% of the Times, also with Whatsapp and OneNote.

Interestingly, the Apps seem to remain even after disabling the non-work version. Haven't yet restarted the phone though.

Maybe related: i just found out, WebApps aren't shown either in the alphabet, only the favorites

@commonuser826
Copy link

Same issue here
On latest apk from github, on latest grapheneos on pixel6a.
I use insular (built on island) instead of shelter for work profiles.
6 of 26 work apps are being displayed.
4 are GOS-apps, 2 are 3rd party apps, and these two are openboard and sandboxed playstore installed from GOS own appstore.
For example two apps that are not being displayed are snapseed and google maps

@commonuser826
Copy link

I still have the same issue and I have tried both of the latest pre releases.
I reckon for me it has to do with apps in the work profile (insular) that has been installed through (sandboxed) google play store.
I do not experience these issues on my main profile.

@8bitPit 8bitPit added planned in progress / implemented Already implemented/fixed or currently in the works and an update will be published soon. labels Apr 17, 2023
@8bitPit
Copy link
Owner

8bitPit commented Apr 26, 2023

Thank you both for reporting. Could you check if the just-released v1.9.3 fixes the work profile issue? https://github.com/8bitPit/Niagara-Issues/releases

@Neon-44
Copy link
Author

Neon-44 commented Apr 26, 2023

Looks good to me 👌

After installing an App in the Work Profile that i don't have in my personal Profile, it immediately shows up and stays after restarting the launcher

Thanks for the Fix :)

Btw, Hobby-Rust-Dev here, just curious, what was the Problem? :)

Edit: closing and re-opening if i get issues

@Neon-44 Neon-44 closed this as completed Apr 26, 2023
@8bitPit
Copy link
Owner

8bitPit commented Apr 30, 2023

Nice @Neon-44, I heard a lot of great things about Rust :D
The issue was a weird one:
For some reason, there are a few apps that constantly tell launcher apps that they have changed, so we refreshed their icons and names and other metadata in our database and refresh our UI. Instagram, for example, does this every thirty minutes, and I found a calendar app that does that every minute! There's probably a bug somewhere inside their codebases. To not unnecessarily waste resources, we check if the app really was updated, by comparing the app's version and changed timestamp. To get the app's version, we have to retrieve the app's metadata from the Android framework. There's a weird bug (?) in the framework that prohibits us to read the app's metadata for work profile apps that are not installed on the main profile, and we handled this edge case wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working in progress / implemented Already implemented/fixed or currently in the works and an update will be published soon.
Projects
None yet
Development

No branches or pull requests

4 participants