Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makeuef V2.4 parity swap bug fix breaking PlayUEF #7

Open
PeterBBCUser opened this issue Apr 7, 2023 · 1 comment
Open

makeuef V2.4 parity swap bug fix breaking PlayUEF #7

PeterBBCUser opened this issue Apr 7, 2023 · 1 comment

Comments

@PeterBBCUser
Copy link

PeterBBCUser commented Apr 7, 2023

There is a new version of Makeuef Ver 2.4 which fixes the long lasting bug of swapping 8e1 8o1 parity which means any new uef files made with makeuef 2.4 will no long be correctly generated in PlayUEF now.
I have made new UEF's (with MakeUEF 2.4) of all the known titles I have come across that use 8e1 8o1 parity on a google drive.
https://drive.google.com/drive/folders/1FXKW4NOKuOC4yf6-W8IoqtxIkrxC2PpL?usp=share_link

@PeterBBCUser
Copy link
Author

Changing the following line
if (version < 3) {parityInvert = 1;
in uef2wave.js
to if (version === 2.3) {parityInvert = 1;
seems to fix the parity problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant