Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit code doesn't reflect success and failure #50

Open
amkay opened this issue Jun 22, 2023 · 0 comments
Open

Exit code doesn't reflect success and failure #50

amkay opened this issue Jun 22, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@amkay
Copy link

amkay commented Jun 22, 2023

Hi!
First of all, thank you all for this great project. It has been a blast using it so far.

Unfortunately I ran into a problem when I tried to send a message that was apparently too big.
Sending the message failed as it should and an error was reported but the process still terminated with exit code 0.
This also happens if a network problem exists, e.g. when you're offline.
I have no idea of Rust but I looked at the code and as far as I understand it this is the behavior for all actions.

This is highly problematic in regards to reliability if you want to send messages automatically, e.g. in a script, and therefore cannot determine if it was successful or not.

The process should at least terminate with something different than 0 if there was an error.
Ideally there should be different exit codes for different types of errors, so that one can differentiate between a user error (like the message being too big) and non-user errors (like network problems, the Matrix instance having temporary problems, etc.).

@8go 8go added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants