Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request RTL #43

Closed
steve-buri opened this issue Oct 6, 2014 · 5 comments
Closed

Feature Request RTL #43

steve-buri opened this issue Oct 6, 2014 · 5 comments

Comments

@steve-buri
Copy link

Hey there,

I like your slider script, great work. Thanks a lot for the fine work.
Have you already planned a right to left version?

Kind regards
Steve

@9bitStudios
Copy link
Owner

Thank you Steve. I'm afraid I'm not entirely sure what you mean by "right to left" version? The slider scrolls both right and left. Could you perhaps elaborate a bit further?

@steve-buri
Copy link
Author

Hey,

when I started to produce the right to left layout for Arabic pages, the
layout broke and the slider did so too. That depended on the CSS attribute
direction = rtl; when I defined it as ltr, everything worked fine again.
But what I miss is the option that the slider runs automatically to the
right side. Currently the autoplay mode moves the images to the left.

To fix it, I used a if case:

if (settings.autoPlay == true) {

setInterval(function() {
    if (canNavigate == true){

        if(isRTL()){
            methods.scrollLeft();
        } else {
            methods.scrollRight();
        }

    }

}, settings.autoPlaySpeed);

}

The "isRTL" function is my personal one depending on jQuery..

best..
Steve

2014-10-06 20:31 GMT+02:00 9bitStudios notifications@github.com:

Thank you Steve. I'm afraid I'm not entirely sure what you mean by "right
to left" version? The slider scrolls both right and left. Could you perhaps
elaborate a bit further?


Reply to this email directly or view it on GitHub
#43 (comment).

@9bitStudios
Copy link
Owner

Ah okay. Sounds like you have resolved this issue then, correct?

@steve-buri
Copy link
Author

Yes, that fixed it.
Annotation: You could add the option to run the player in both directions, depending on the setting "left" or "right".

@ziymed
Copy link

ziymed commented May 9, 2017

what is the isRTL function code pls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants