Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player Name in Event #76

Closed
BlueTree242 opened this issue Oct 27, 2021 · 5 comments
Closed

Player Name in Event #76

BlueTree242 opened this issue Oct 27, 2021 · 5 comments
Labels
feature New feature or request
Milestone

Comments

@BlueTree242
Copy link
Contributor

PostPunishEvent PostPardonEvent

It is possible that these punishments are IP Punishments. But I would like to know the name of the player that was punished even it is an ip ban. Since the player uses /ipban name the player name is known, could it be included in the event? i need this so much.

@D3adhkwen
Copy link
Contributor

I agree to this as well. If this is added, it should be possible to show player name instead of IP in BanAnnouncer (privacy purposes).

@BlueTree242
Copy link
Contributor Author

yes! my plugin does something simmilar to ban annoucer that is why im requesting this

@A248
Copy link
Owner

A248 commented Oct 27, 2021

It is also possible to directly ban an IP address using /ipban, in which case, there is no player name. For example, /ipban 127.0.0.1.

The main issue here is that an IP ban does not apply to a single player, but rather multiple accounts. It wouldn't be entirely correct to say there is a single player related to an IP ban, so exposing this in the API might not be the right course of action here.

If you want to, you can iterate over all players to find out which ones would be affected by an IP ban. That will give you a rough approximation of the players who will be banned by an IP ban.

LibertyBans' enforcement of IP-based punishments is more complicated than finding all players with the banned IP address, however. Perhaps I should expose an API to obtain the players who would be banned by a punishment which is about to be enacted.

@BlueTree242
Copy link
Contributor Author

I am thinking of a method of Punish/PardonEvent#getName to return name of player if known, null if the only information known is the ip

@BlueTree242
Copy link
Contributor Author

The player name can be obtained from command args.

@KoxSosen KoxSosen added the feature New feature or request label Jan 2, 2022
@A248 A248 added this to the 1.1.0 milestone Jul 21, 2023
@A248 A248 closed this as completed in ae2dfae Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants