Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The mod mistake one side as the loading bar in 1.16.1 with optifine #1

Closed
Fox2Code opened this issue Jul 5, 2020 · 4 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@Fox2Code
Copy link

Fox2Code commented Jul 5, 2020

The screenshot is self-explanatory

LoadingRed

:3

Also added logs: 2020-07-05-1.log

@A5b84
Copy link
Owner

A5b84 commented Jul 5, 2020

It's caused by OptiFine, should be pretty easy to fix so I guess I'll do that (at some point)

Meanwhile you can use this instead of my mod as a dirty workaround

@A5b84 A5b84 added the bug Something isn't working label Jul 5, 2020
@A5b84 A5b84 self-assigned this Jul 5, 2020
@Fox2Code
Copy link
Author

Fox2Code commented Jul 5, 2020

I found that it thinks that the left thingy is the bar color

https://github.com/A5b84/dark-loading-screen/blob/master/src/main/java/io/github/a5b84/darkloadingscreen/mixin/SplashScreenMixin.java
So maybe putting the Bar color index and the Optifine color index and give appropriate value depending on if Optifine is loaded or not

Also alternatively you could do a hax to inject assets/minecraft/optifine/color.properties dynamically if Optifine is loaded

For now, I put the bar color the sames as the border color :3

@Fox2Code Fox2Code changed the title One side of loading is red in 1.16.1 (Others arent) The mod mistake one side as the loading bar in 1.16 Jul 5, 2020
@Fox2Code Fox2Code changed the title The mod mistake one side as the loading bar in 1.16 The mod mistake one side as the loading bar in 1.16.1 with optifine Jul 5, 2020
@A5b84
Copy link
Owner

A5b84 commented Jul 5, 2020

A 1.16 snapshot (20w22a) had the same issue because the way the bar was rendered before was with 3 rectangles on top of each other (a black one for the outline, then a white one (same color as the vanilla background), and then the red one), and it was changed to 4 1-wide black rectangles and a red one, and I think OptiFine just reverts that change

Anyway, using the old mixins when optifine is present should fix it, haven't tested yet but it should be working

@A5b84
Copy link
Owner

A5b84 commented Jul 6, 2020

Turns out that OptiFIne actually calls fill one more time that vanilla and it doesn't appear to be visible (it's the white one, maybe it's for the bar background but I'm too lazy to check ¯\_(ツ)_/¯ )

Anyway, easy to fix so expect a new version soon :>

OptiFine fill ordinals

@A5b84 A5b84 closed this as completed in 417cc95 Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants