Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3.0] Issue with validating InternationalAIN #91

Open
MichaelJRussell opened this issue Feb 21, 2024 · 1 comment
Open

[v3.0] Issue with validating InternationalAIN #91

MichaelJRussell opened this issue Feb 21, 2024 · 1 comment
Labels
In Draft Draft changes in pendingChanges branch Resolved? Issue is probably resolved and pending closure.
Milestone

Comments

@MichaelJRussell
Copy link
Contributor

MichaelJRussell commented Feb 21, 2024

I found an issue with our handling of the new support for international AINs, and while testing that, I found that all CVIs using the InternationalAIN element are being flagged as invalid. The issue seems to be with this block defining the allowed tag elements, it's missing the InternationalAIN option, so no CVIs with that element will be considered valid:

eCVI/ecvi2.xsd

Lines 1039 to 1049 in 6684182

<xs:choice>
<xs:element ref="AIN"/>
<xs:element ref="MfrRFID"/>
<xs:element ref="NUES9"/>
<xs:element ref="NUES8"/>
<xs:element ref="OtherOfficialID"/>
<xs:element ref="ManagementID"/>
<xs:element ref="BrandImage"/>
<xs:element ref="EquineDescription"/>
<xs:element ref="EquinePhotographs"/>
</xs:choice>

Am I missing something? This seems like a major blocker to implementing v3 unless/until that gets resolved.

Edit: I generated an example CVI using fake data to demonstrate the issue: https://gist.github.com/MichaelJRussell/0ebd2c8227c9dbd358b756312be4972b

@MichaelJRussell
Copy link
Contributor Author

MichaelJRussell commented Feb 21, 2024

I'm unclear on what the process is for making changes to the standard for fixing issues outside of the normal release cadence, but I went ahead and opened up a pull request for discussion / consideration to implement the change needed to use InternationalAIN as a valid animal tag: #92

@ryanscholzdvm ryanscholzdvm added this to the 3.0.1 milestone Mar 21, 2024
@ryanscholzdvm ryanscholzdvm added In Draft Draft changes in pendingChanges branch Resolved? Issue is probably resolved and pending closure. labels May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
In Draft Draft changes in pendingChanges branch Resolved? Issue is probably resolved and pending closure.
Projects
None yet
Development

No branches or pull requests

2 participants