Merge v2.2 into master #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use global.json specified SDK
When Channel.ProcessOutboundTransmissionsAsync has not yet processed the written and flushed buffer by the time Channel.Dispose is called, the channel can end up terminating before the content is transmitted. Repros #88 (occasionally, or with debugger help in timing)
Similar fix to what we had to [fix in streamjsonrpc][1] a while ago. [1]: microsoft/vs-streamjsonrpc#176
Flush stream within semaphore
Frames received for a channel after its local disposal are now discarded. Any pending write+flush to the channel's PipeWriter is canceled so as to avoid plugging up the multiplexing stream when the disposed channel hasn't drained its own pipe. When a Channel is disposed after writing and flushing bytes, a Channel that manages its own Pipe will complete transmission before actual disposal. Channels initialized with an ExistingPipe will terminate without guaranteeing that writes are completed, since we don't have any way of knowing when writes are done if the writer is not completed (which is our recommended path for disposing channels). Fixes #88
Fix Channel.Dispose to handle pending sends/receives
Codecov Report
@@ Coverage Diff @@
## master #94 +/- ##
==========================================
+ Coverage 90% 90.06% +0.06%
==========================================
Files 31 31
Lines 2101 2175 +74
Branches 372 397 +25
==========================================
+ Hits 1891 1959 +68
- Misses 174 179 +5
- Partials 36 37 +1
Continue to review full report at Codecov.
|
AArnott
pushed a commit
that referenced
this pull request
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.