Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freshen this repo up #38

Closed
AArnott opened this issue May 13, 2020 · 3 comments · Fixed by #40
Closed

Freshen this repo up #38

AArnott opened this issue May 13, 2020 · 3 comments · Fixed by #40
Assignees

Comments

@AArnott
Copy link
Owner

AArnott commented May 13, 2020

This repo hasn't been updated for a while, and is used by some popular packages.

Let's get it up to date with the latest stuff from its cousin Microsoft.VisualStudio.Validation.

@AArnott AArnott self-assigned this May 13, 2020
@scottdorman
Copy link
Contributor

Having just stumbled across it's cousin, why have (and maintain) both libraries? Outside of the fact that Microsoft.VisualStudio.Validation is newer (and mis-named since nothing in the code has anything to do with Visual Studio), wouldn't it be better to just merge the two (and maybe rename it)?

@AArnott
Copy link
Owner Author

AArnott commented Sep 18, 2020

I think renaming it would appear to create a 3rd one. I think the name Validation is ideal, but I don't think I can pull of deprecating either one in favor of the other because both are heavily used.
I might at least make them as nearly identical in feature set as possible, but then... that's just extra work for me and if folks want more functionality they can switch to the MS.VS.Validation one which gets more attention.

So I'm divided.

@scottdorman
Copy link
Contributor

Yes, it's definitely the ideal name. I guess what would be best is to somehow share the code between them to keep them in sync (a git submodule maybe?) although I'm not sure how that would realistically work.

Up until yesterday, I'd never heard of the MS.VS.Validation package so, to me at least, there is a discoverability issue for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants